Skip to content

Propose OSS page #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaywonchung merged 8 commits into from
Mar 18, 2025
Merged

Propose OSS page #282

jaywonchung merged 8 commits into from
Mar 18, 2025

Conversation

@majunze2001
Copy link
Collaborator

@majunze2001 majunze2001 commented Oct 26, 2024

Supported features:

  • Display both GitHub projects and non-GitHub projects. GitHub projects will display the repo details including language, the number of forks, and the number of stars fetched from the GitHub API.
  • Supports optional project logo.
  • Supports organizing projects into subsections with separate descriptions.

See source/oss/index.md for details.

@majunze2001
Propose OSS page
c9fc854 
- Integrated GitHub REST API with template CSS.
- See source/oss/index.md for details.
@mosharaf mosharaf requested a review from jaywonchung November 2, 2024 01:44
@jaywonchung
Copy link
Member

jaywonchung commented Nov 2, 2024

A screenshot would be helpful. Also, there is placeholder text in the body of the page, so I don't think this PR is intended to be merged yet.

@mosharaf
Copy link
Member

mosharaf commented Nov 21, 2024

@majunze2001 Can you please restart this?

@jaywonchung
Copy link
Member

jaywonchung commented Mar 18, 2025 •
edited
Loading

Screenshot 2025-03-18 at 4 14 40 PM @mosharaf This is what is looks like now. Project descriptions are based on their GitHub repo description. Please let us know the projects you'd like to have on the final page and I'll add those.

@mosharaf
Copy link
Member

mosharaf commented Mar 18, 2025

I was just typing why the two boxes with and without icons have texts misaligned :)

@mosharaf
Copy link
Member

mosharaf commented Mar 18, 2025

This looks very good for a start! Great work @majunze2001 @jaywonchung

@jaywonchung jaywonchung requested a review from mosharaf March 18, 2025 20:18
mosharaf
mosharaf reviewed Mar 18, 2025
View reviewed changes
mosharaf
mosharaf reviewed Mar 18, 2025
View reviewed changes
mosharaf
mosharaf reviewed Mar 18, 2025
View reviewed changes
mosharaf
mosharaf reviewed Mar 18, 2025
View reviewed changes
mosharaf
mosharaf requested changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mosharaf mosharaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but looks good otherwise. I think we can iterate over the projects to include and texts to have over time.

@majunze2001 majunze2001 requested a review from mosharaf March 18, 2025 20:34
mosharaf
mosharaf approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mosharaf mosharaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jaywonchung jaywonchung merged commit 1e3593d into SymbioticLab:develop Mar 18, 2025
1 check passed
@jaywonchung jaywonchung deleted the oss-page-jeffjma-v2 branch March 18, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosharaf mosharaf mosharaf approved these changes

@jaywonchung jaywonchung Awaiting requested review from jaywonchung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@majunze2001 @jaywonchung @mosharaf